Remove host image build option to skip SMS push #756
Merged
+5
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes an input option on the overcloud host image build workflow that allowed the user to not push the built image to SMS. This function was useful in testing but in practice serves little use. Images that are not in SMS cannot be used in the default stackhpc kayobe configuration because they are used in CI.
markgoddard
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes an input option on the overcloud host image build workflow that allowed the user to not push the built image to SMS. This function was useful in testing but in practice serves little use. Images that are not in SMS cannot be used in the default stackhpc kayobe configuration because they are used in CI.
All it does is create confusion and make people manually upload images.