Skip to content

Check if repos backup exists in kolla footer #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 14, 2023
Merged

Check if repos backup exists in kolla footer #775

merged 4 commits into from
Nov 14, 2023

Conversation

MoteHue
Copy link
Contributor

@MoteHue MoteHue commented Nov 13, 2023

When a child service is build, such as neutron-infoblox-ipam-agent being a child of neutron-server, the fotoer is ran twice.

This means it fails as the repo backup has already been moved.

@MoteHue MoteHue requested a review from markgoddard November 13, 2023 09:28
@MoteHue MoteHue requested a review from a team as a code owner November 13, 2023 09:28
@MoteHue
Check if repos backup exists in kolla footer
be9efd1 
When a child service is build, such as neutron-infoblox-ipam-agent
being a child of neutron-server, the fotoer is ran twice.

This means it fails as the repo backup has already been moved.
@MoteHue MoteHue force-pushed the fix-child-container-builds branch from 6faeac5 to be9efd1 Compare November 13, 2023 09:32
@MoteHue
Copy link
Contributor Author

MoteHue commented Nov 13, 2023

Example failure here: https://github.com/stackhpc/stackhpc-kayobe-config/actions/runs/6826625196/job/18568857784

@MoteHue MoteHue mentioned this pull request Nov 13, 2023
Merged
jovial
jovial reviewed Nov 13, 2023
View reviewed changes
@jovial
Copy link
Contributor

jovial commented Nov 13, 2023 •
edited
Loading

I guess this also means we wouldn't use pulp in the images that build on an image where the footer has already run?

jovial
jovial reviewed Nov 13, 2023
View reviewed changes
@MoteHue MoteHue force-pushed the fix-child-container-builds branch from dcd3728 to 3be5458 Compare November 13, 2023 10:40
jovial
jovial previously approved these changes Nov 13, 2023
View reviewed changes
markgoddard
markgoddard suggested changes Nov 13, 2023
View reviewed changes
markgoddard
markgoddard reviewed Nov 13, 2023
View reviewed changes
@MoteHue MoteHue force-pushed the fix-child-container-builds branch from 985146c to 7c2f630 Compare November 13, 2023 14:04
markgoddard
markgoddard reviewed Nov 13, 2023
View reviewed changes
Copy link
Contributor

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please update once tested.

@MoteHue
Copy link
Contributor Author

MoteHue commented Nov 14, 2023 •
edited
Loading

LGTM, please update once tested.

Tested and the builds got much further than before, so I believe this has fixed things. (The test build was cancelled after two hours due to not being needed).

Could hold off for a complete build test if that's preferable

@markgoddard
Copy link
Contributor

LGTM, please update once tested.

Tested and the builds got much further than before, so I believe this has fixed things. (The test build was cancelled after two hours due to not being needed).

Could hold off for a complete build test if that's preferable

Did it build the neutron infoblox image that was previously broken?

@MoteHue
Copy link
Contributor Author

MoteHue commented Nov 14, 2023

LGTM, please update once tested.

Tested and the builds got much further than before, so I believe this has fixed things. (The test build was cancelled after two hours due to not being needed).
Could hold off for a complete build test if that's preferable

Did it build the neutron infoblox image that was previously broken?

Yes, had a successful build here: https://github.com/stackhpc/stackhpc-kayobe-config/actions/runs/6863952531/job/18664728341

@markgoddard markgoddard merged commit 70d22e4 into stackhpc/yoga Nov 14, 2023
@markgoddard markgoddard deleted the fix-child-container-builds branch November 14, 2023 14:36
@MoteHue MoteHue mentioned this pull request Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markgoddard markgoddard markgoddard approved these changes

@jovial jovial jovial left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MoteHue @jovial @markgoddard