Skip to content

Skip docker registry login by default, login only when pulp is deployed #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Skip docker registry login by default, login only when pulp is deployed #891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac809cb
Skip docker registry login by default, login only when pulp is deployed
MoteHue Jan 19, 2024
4a20e11
Update etc/kayobe/environments/aufn-ceph/a-universe-from-nothing.sh
MoteHue Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions etc/kayobe/containers/pulp/post.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,10 @@
when:
- stackhpc_pulp_sync_for_local_container_build | bool
- pulp_settings.changed

- name: Login to docker registry
docker_login:
registry_url: "{{ kolla_docker_registry or omit }}"
username: "{{ kolla_docker_registry_username }}"
password: "{{ kolla_docker_registry_password }}"
reauthorize: yes
2 changes: 1 addition & 1 deletion etc/kayobe/environments/aufn-ceph/a-universe-from-nothing.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ kayobe seed vm provision
kayobe seed host configure

# Deploy local pulp server as a container on the seed VM
kayobe seed service deploy --tags seed-deploy-containers --kolla-tags none -e deploy_containers_registry_attempt_login=False
kayobe seed service deploy --tags seed-deploy-containers --kolla-tags none

# Deploying the seed restarts networking interface, run configure-local-networking.sh again to re-add routes.
$KAYOBE_CONFIG_PATH/environments/$KAYOBE_ENVIRONMENT/configure-local-networking.sh
Expand Down
4 changes: 4 additions & 0 deletions etc/kayobe/seed.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,10 @@ seed_containers: >-

seed_extra_containers: {}

# Whether to attempt a basic authentication login to a registry when
# deploying seed containers
seed_deploy_containers_registry_attempt_login: "{{ not seed_pulp_container_enabled | bool }}"

###############################################################################
# Seed node firewalld configuration.

Expand Down