Skip to content

Allow aio jobs to be cancelled (yoga) #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

MaxBed4d
Copy link
Contributor

@MaxBed4d MaxBed4d commented Feb 9, 2024

Allow aio jobs to be cancelled

@MaxBed4d MaxBed4d force-pushed the Enable-Job-Cancellation branch 7 times, most recently from ede3484 to c56666c Compare February 9, 2024 12:19
@MaxBed4d
Copy link
Contributor Author

MaxBed4d commented Feb 9, 2024

This is now successfully capable of cancelling any of the job's tasks upon cancellation request and if the pull request workflow is cancelled the AiO job will also be cancelled.
The AiO job can be cancelled during executed steps.

@MaxBed4d MaxBed4d requested a review from Alex-Welsh February 9, 2024 12:25
@MaxBed4d MaxBed4d force-pushed the Enable-Job-Cancellation branch 2 times, most recently from 1ebcadf to d72362c Compare February 9, 2024 14:15
@MaxBed4d MaxBed4d marked this pull request as ready for review February 9, 2024 14:18
@MaxBed4d MaxBed4d requested a review from a team as a code owner February 9, 2024 14:18
@MaxBed4d MaxBed4d force-pushed the Enable-Job-Cancellation branch from 0955dca to 9c0e3dd Compare February 9, 2024 15:04
@MaxBed4d MaxBed4d closed this Feb 9, 2024
@MaxBed4d MaxBed4d force-pushed the Enable-Job-Cancellation branch from 9c0e3dd to 699bced Compare February 9, 2024 15:47
@MaxBed4d MaxBed4d reopened this Feb 9, 2024
Alex-Welsh
Alex-Welsh previously approved these changes Feb 9, 2024
Copy link
Member

@Alex-Welsh Alex-Welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markgoddard markgoddard changed the title Test job to see if we can cancel midway through. Allow aio jobs to be cancelled (yoga) Feb 20, 2024
@markgoddard
Copy link
Contributor

Verified that both the build-kayobe-image and aio workflows can be cancelled. After cancelling an aio workflow the VM instance is destroyed.

@markgoddard markgoddard merged commit 5ddab7d into stackhpc/yoga Feb 20, 2024
@markgoddard markgoddard deleted the Enable-Job-Cancellation branch February 20, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants