Skip to content

Correct OpenSearch migration instructions #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

MoteHue
Copy link
Contributor

@MoteHue MoteHue commented Feb 9, 2024

Because we set kolla_enable_central_logging: true, kolla_enable_elsticsearch is also set to true, as per the Kayobe defaults:

kolla_enable_elasticsearch: "{{ not kolla_base_distro == 'rocky' and (kolla_enable_central_logging | bool or kolla_enable_osprofiler | bool or kolla_enable_skydive | bool or kolla_enable_monasca | bool) }}"

Update the instructions to disbale Elasticsearch explicitly.

Because we set ``kolla_enable_central_logging: true``,
``kolla_enable_elsticsearch`` is also set to true, as per the Kayobe
defaults:

```
kolla_enable_elasticsearch: "{{ not kolla_base_distro == 'rocky' and (kolla_enable_central_logging | bool or kolla_enable_osprofiler | bool or kolla_enable_skydive | bool or kolla_enable_monasca | bool) }}"
```

Update the instructions to disbale Elasticsearch explicitly.
@MoteHue MoteHue requested a review from technowhizz February 9, 2024 16:05
@MoteHue MoteHue requested a review from a team as a code owner February 9, 2024 16:05
Copy link
Contributor

@technowhizz technowhizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely 👍

@dougszumski
Copy link
Member

dougszumski commented Feb 13, 2024

Because we set kolla_enable_central_logging: true, kolla_enable_elsticsearch is also set to true, as per the Kayobe defaults:

kolla_enable_elasticsearch: "{{ not kolla_base_distro == 'rocky' and (kolla_enable_central_logging | bool or kolla_enable_osprofiler | bool or kolla_enable_skydive | bool or kolla_enable_monasca | bool) }}"

Update the instructions to disbale Elasticsearch explicitly.

Hmm, shouldn't kolla_enable_elasticsearch evaluate to False for Rocky in the above? And for other distros, in Yoga, they should be using Elastic?

See: https://review.opendev.org/c/openstack/kolla-ansible/+/875729

@technowhizz
Copy link
Contributor

We hit an issue with Ubuntu 😅

@MoteHue
Copy link
Contributor Author

MoteHue commented Feb 13, 2024

And for other distros, in Yoga, they should be using Elastic?

We need to run the OpenSearch migration in Yoga prior to upgrading to Zed, regardless of distro. At worst, these instructions give us a redundant instance of enable_opensearch that would be deleted when the default is changed to OpenSearch in Zed anyway. As Dawud said, the instructions are currently wrong for Ubuntu systems

Copy link
Member

@dougszumski dougszumski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying

@MoteHue MoteHue merged commit aeaf2bf into stackhpc/yoga Feb 13, 2024
@MoteHue MoteHue deleted the correct-opensearch-migration-instructions branch February 13, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants