CI: Avoid leaking credentials in container image builds #937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
markgoddard
commented
Feb 13, 2024
markgoddard
commented
- Revert "Don't verify Apt repo CA initially when using HTTPS in container build"
- Revert "Add package repository credentials to container image build"
- Add Ansible Galaxy roles and collections to .gitignore
- Add a playbook to deploy an authenticating Pulp proxy
- Use authenticating Pulp proxy during container image builds
…ner build" This reverts commit f8947a9. This approach is not secure and leaves credentials in images.
This reverts commit 05e1995. This approach is not secure and leaves credentials in images.
There is currently no practical, secure way to provide credentials for accessing Ark's authenticated package repositories from within a Kolla build. Docker provides build secrets, but these must be explicitly requested for each RUN statement, making them challenging to use in Kolla. This change adds a playbook that deploys an Nginx container that runs as a reverse proxy, injecting an HTTP basic authentication header into requests. Because this proxy bypasses Pulp's authentication, it must not be exposed to any untrusted environment. [1] https://docs.docker.com/build/building/secrets/
markgoddard
force-pushed
the
yoga-secure-container-builds
branch
from
250fb76 to
bd03772
Compare
This change uses the authenticating Pulp proxy added in 6320be9 to provide container image builds access to Ark's authenticated package repositories without injecting the credentials into the built images or their metadata.
markgoddard
force-pushed
the
yoga-secure-container-builds
branch
from
bd03772 to
9f940b7
Compare
Running the hello-world container from Dockerhub at the beginning of workflows can cause us to hit rate limits. Switch to a simple docker ps.
|
AIO jobs are failing with an issue seen upstream: |
Alex-Welsh
approved these changes
Feb 13, 2024
| - name: Install Docker Python SDK | ||
| run: | | ||
| pip install --user docker | ||
| sudo pip install docker |
There was a problem hiding this comment.
Not ideal, but necessary with connection=local and ansible_python_interpreter=/usr/bin/python3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.