Skip to content

Bump magnum-capi-helm version to latest #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

sd109
Copy link
Member

@sd109 sd109 commented Feb 29, 2024

No description provided.

@sd109 sd109 requested a review from a team as a code owner February 29, 2024 09:41
@Alex-Welsh
Copy link
Member

Is this something that only needs to happen in antelope or is it worth doing in Yoga & Zed as well?

@Alex-Welsh
Copy link
Member

Also, probably worth rebuilding the container and adding the tags to this PR (along with a release note)

@mnasiadka
Copy link
Member

I don't think we're planning to use CAPI in Yoga (at least I'm not aware of it) - so Antelope is fine.

@scrungus
Copy link
Contributor

@mnasiadka > I don't think we're planning to use CAPI in Yoga (at least I'm not aware of it) - so Antelope is fine.

We'll be wanting to use it at ECMWF, so I think we'd need to backport to yoga

@markgoddard
Copy link
Contributor

pep8 failed:

etc/kayobe/kolla-image-tags.yml
20:54 error no new line character at the end of file (new-line-at-end-of-file)

Seems a bit harsh to me :)

I'm happy to merge here first then backport to yoga.

Copy link
Member

@Alex-Welsh Alex-Welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: missing eof newlines on kolla-image-tags.yml and the release note
otherwise LGTM as long as those new images are tested.

@markgoddard
Copy link
Contributor

I'm going to merge the yoga change through to zed + antelope, and I'll pick up the tags from this PR for antelope.

@markgoddard markgoddard closed this Mar 1, 2024
@markgoddard markgoddard deleted the fix/bump-magnum-capi-helm branch March 1, 2024 10:12
@markgoddard
Copy link
Contributor

2023.1: #969
zed: #967

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants