Fix container image promotion (hopefully) #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change modifies the way in which we promote container image tags. Previously, the stackhpc-dev container repository was configured as a remote, and the stackhpc repository synced with it, using include_tags to limit to a specific tag. Now, we use the "Add content" [1] API to add container tags from stackhpc-dev to stackhpc. Currently we're still promoting a single tag across all repositories, so a non-existent tag is not an error. This will change in future. [1] https://docs.pulpproject.org/pulp_container/restapi.html#tag/Repositories:-Container/operation/repositories_container_container_add
|
The uri tasks may need to be rewritten in python if we find this is too slow. |
|
Now rewritten in Python. Seems to save about 30s for a single image promotion. Extrapolating to all images this could be significant. https://github.com/stackhpc/stackhpc-release-train/actions/runs/4630657493/jobs/8192517775 |
|
Moving the role to the collection: stackhpc/ansible-collection-pulp#59 |
This is available in stackhpc.pulp collection v0.5.0, and is implemented in Python for a speed up.
markgoddard
force-pushed
the
container-promote-mk2
branch
from
1f53e24 to
209096e
Compare
mnasiadka
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies the way in which we promote container image tags.
Previously, the stackhpc-dev container repository was configured as a
remote, and the stackhpc repository synced with it, using include_tags
to limit to a specific tag.
Now, we use the "Add content" [1] API to add container tags from
stackhpc-dev to stackhpc. Currently we're still promoting a single tag
across all repositories, so a non-existent tag is not an error. This
will change in future.
[1] https://docs.pulpproject.org/pulp_container/restapi.html#tag/Repositories:-Container/operation/repositories_container_container_add