Skip to content

Filter for https mirrors where possible #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

Alex-Welsh
Copy link
Member

@Alex-Welsh Alex-Welsh commented Sep 5, 2024

Currently a bunch of the mirrors in these mirrorlists are insecure. This change adds another filter to only use https mirrors

@Alex-Welsh Alex-Welsh requested a review from a team as a code owner September 5, 2024 12:27
@MoteHue
Copy link
Contributor

MoteHue commented Sep 5, 2024

I was looking through the links to make sure that this change won't limit the remaining number of mirrors too much (this seems fine, there's plenty of https ones).
However, I did notice the RL9.1 links are returning invalid:
# repo = rocky-AppStream-9.1 arch = x86_64 error: invalid repo or arch
I realise this isn't a big issue, because we already don't sync these (sync=false). But I'm wondering if it's even worth updating the queries to https in these cases

@Alex-Welsh
Copy link
Member Author

I was looking through the links to make sure that this change won't limit the remaining number of mirrors too much (this seems fine, there's plenty of https ones). However, I did notice the RL9.1 links are returning invalid: # repo = rocky-AppStream-9.1 arch = x86_64 error: invalid repo or arch I realise this isn't a big issue, because we already don't sync these (sync=false). But I'm wondering if it's even worth updating the queries to https in these cases

Yeah, all the RL8/CS8 ones do too. It's just because they're out of date. I think to be honest we need to go through them all and remove all the ones that are broken. But that's a separate job.

I just changed all the RL9 repos

@Alex-Welsh Alex-Welsh merged commit 9095758 into main Sep 6, 2024
3 checks passed
@Alex-Welsh Alex-Welsh deleted the https-mirrorlists branch September 6, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants