Skip to content

update README #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2023
Merged

update README #39

merged 1 commit into from
Dec 20, 2023
+21 −18

Conversation

Alex-Welsh
Copy link
Member

No description provided.

MoteHue
MoteHue reviewed Dec 19, 2023
View reviewed changes
README.rst Outdated
multinode_flavor = "changeme"
multinode_image = "CentOS-stream8-lvm"
multinode_flavor = "general.v1.medium"
multinode_image = "overcloud-rocky-9-yoga-20231026T081556"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any particular reason to use this image, and not Rocky9-lvm?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rocky9-lvm gets updated somewhat regularly. Pinning to a specific image improves reliability

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plus making it more accurate to production is better

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we'd use the image tag defined in SKC, but this will do for now

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed my mind, I've just remembered that the overcloud* images have some awkward issues with vault at the moment that haven't yet been resolved

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed my mind, I've just remembered that the overcloud* images have some awkward issues with vault at the moment that haven't yet been resolved

Will want to change the Ubuntu image mentioned later in the document too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@markgoddard markgoddard merged commit 71699d2 into main Dec 20, 2023
@markgoddard markgoddard deleted the update-readme branch December 20, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoteHue MoteHue MoteHue left review comments

@markgoddard markgoddard markgoddard approved these changes

@seunghun1ee seunghun1ee Awaiting requested review from seunghun1ee

@jackhodgkiss jackhodgkiss Awaiting requested review from jackhodgkiss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alex-Welsh @markgoddard @MoteHue