Skip to content

Fix templating for docker build in deploy template #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

Alex-Welsh
Copy link
Member

I'm amazed this hasn't come up before but the templating is wrong for the docker image build so it currently fails. It seems that $ only needs to be escaped when it's at the start of a 'word'

Copy link

@MaxBed4d MaxBed4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change has the potential to be revolutionary. I approve.

@Alex-Welsh Alex-Welsh merged commit c8867ae into main Jan 23, 2024
@markgoddard markgoddard deleted the fix-tempest-build branch June 7, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants