Fix issue building kayobe image #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A regression was introduced in: #55 which meant that the Kayobe docker image failed to build. This is because requirements.txt was updated to point a local path that did not exist inside the docker image during the build. I've changed the logic to update the requirements.txt to use the ansible variables that configure the kayobe checkout.
markgoddard
approved these changes
Jun 26, 2024
markgoddard
added a commit
that referenced
this pull request
Jul 24, 2024
Yoga & earlier deployments have been broken since the following related changes: #55 #59 #60 The above changes switched to installing Kayobe using SKC's requirements.txt, avoiding the need for a local copy of the repository. This breaks Yoga & earlier releases which require symlinks in etc/kayobe/ansible/ to correctly resolve to a Kayobe source repo. This change reverts to cloning a Kayobe repository when using Yoga & earlier releases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression was introduced in:
#55
which meant that the Kayobe docker image failed to build. This is because requirements.txt was updated to point a local path that did not exist inside the docker image during the build. I've changed the logic to update the requirements.txt to use the ansible variables that configure the kayobe checkout.