Skip to content

Use bash for all shell tasks #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Use bash for all shell tasks #71

merged 1 commit into from
Sep 9, 2024

Conversation

markgoddard
Copy link

Without this we see the following issue during Ubuntu upgrades:

'/bin/sh: 1: [[: not found'

In the 'Revert TLS changes to avoid git conflicts (upgrade)' task in
deploy-openstack-config.yml.

Without this we see the following issue during Ubuntu upgrades:

  '/bin/sh: 1: [[: not found'

In the 'Revert TLS changes to avoid git conflicts (upgrade)' task in
deploy-openstack-config.yml.
@markgoddard markgoddard requested a review from a team as a code owner September 9, 2024 09:14
@markgoddard markgoddard self-assigned this Sep 9, 2024
Copy link
Member

@Alex-Welsh Alex-Welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an argument to be made for an audit of the usage of shell: vs command: here but I think that's unnecessarily nitpicky at the moment

@markgoddard markgoddard merged commit 17e498c into main Sep 9, 2024
@markgoddard markgoddard deleted the more-bash branch September 9, 2024 09:34
@markgoddard
Copy link
Author

There's an argument to be made for an audit of the usage of shell: vs command: here but I think that's unnecessarily nitpicky at the moment

I think all of these require shell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants