Add async callback #8105
Merged
Add async callback #8105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomeHirata
reviewed
Apr 25, 2025
|
|
||
| return async_wrapper | ||
|
|
||
| else: |
There was a problem hiding this comment.
nit: we could remove this else condition
TomeHirata
reviewed
Apr 25, 2025
|
|
||
| def _execute_start_callbacks(instance, fn, call_id, callbacks, args, kwargs): |
There was a problem hiding this comment.
nit: since they are internal methods within with_callbacks, we don't need to add "_" prefix.
TomeHirata
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #8103, but instead of using the generator, we break down the code.