Skip to content

Restore relaxation of openai version range, lost after refactor #8112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025

Conversation

srowen
Copy link
Contributor

@srowen srowen commented Apr 25, 2025

Recently, #8075 was opened to note that limiting openai to version 1.61.0 was causing problems.

This was fixed for 2.6.18 in #8084 . However that change only changed one of two entries in pyproject.toml that defines the openai range, as there were parallel configurations of dependencies for poetry and uv.

Then, just before 2.6.19, this PR removed the poetry-oriented dependencies, including the openai change:
0363c2e#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711L36-L106

Now, pyproject.toml is left with the other copy which still has the version limit of 1.61.0:
https://github.com/stanfordnlp/dspy/blob/main/pyproject.toml#L27

This just completes the intent of the original change by removing the version limit on openai.

CC @okhat @chenmoneygithub

@okhat
Copy link
Collaborator

okhat commented Apr 25, 2025

Ah, thanks so much @srowen !

@okhat okhat merged commit 63ec24e into stanfordnlp:main Apr 25, 2025
3 checks passed
@srowen srowen deleted the restore_openai_range branch April 25, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants