-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Increasing test coverage for JsonAdapter #8131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increasing test coverage for JsonAdapter #8131
Conversation
Fixes: #8121 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! left some comments to simplify the test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing! Overall LGTM, I will take over the cleanup and merge it. Thanks again for the conbribution!
I'm glad I could help. Thanks for handling the cleanup and merge! |
This PR adds three additional test cases for the JsonAdapter:
All tests could be passed locally.
If there are any mistakes in my attempt, I sincerely apologize and appreciate you taking the time to review my pull request. I have great respect for your work. Thanks.