Skip to content

Fix cache thread unsafety #8133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

Fix cache thread unsafety #8133

merged 1 commit into from
Apr 28, 2025
+43 −23

Conversation

chenmoneygithub
Copy link
Collaborator

@chenmoneygithub chenmoneygithub commented Apr 28, 2025 •
edited
Loading

Instead of tying the args to ignore to the cache instance, we just use it at call time.

@chenmoneygithub chenmoneygithub requested a review from okhat April 28, 2025 20:49
@okhat okhat merged commit e20c5e9 into stanfordnlp:main Apr 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okhat okhat Awaiting requested review from okhat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenmoneygithub @okhat