MIPROv2 Updates #8166
Merged
MIPROv2 Updates #8166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klopsahlong
commented
May 3, 2025
| num_fewshot_candidates: Optional[int] = None, | ||
| num_instruct_candidates: Optional[int] = None, | ||
| auto: Optional[Literal["light", "medium", "heavy"]] = "light", | ||
| num_candidates: Optional[int] = None, |
There was a problem hiding this comment.
Setting auto back to light as default & making num_candidates=None by default. I also removed setting num_fewshot & num_instruct_candidates from init, since this overcomplicates the logic of the error message below and was not available to users before anyways.
klopsahlong
commented
May 3, 2025
| num_vars *= 2 # Account for few-shot examples + instruction variables | ||
| # Trials = MAX(c*M*log(N), c=2, 3/2*N) | ||
| num_trials = int(max(2 * num_vars * np.log2(num_candidates), 1.5 * num_candidates)) | ||
|
|
There was a problem hiding this comment.
Note: this both refactors the num_trials calculator as a helper function, so that we can use it in the error message as well, AND changes np.log --> np.log2.
klopsahlong
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logbase 2 in thenum_trialscalculation, as was originally intended.