Skip to content

add more permission capabilities to PythonInterpreter #8296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 4, 2025

Conversation

arnavsinghvi11
Copy link
Collaborator

improving the PythonInterpreter with higher permissions

@arnavsinghvi11 arnavsinghvi11 changed the title [WIP] add more permission capabilities to PythonInterpreter add more permission capabilities to PythonInterpreter May 30, 2025
Copy link
Collaborator

@chenmoneygithub chenmoneygithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice extension to PythonInterpreter! Left some comments.

Btw, I am working on a pure python-based code runner, as Pyodide is not really designed for this purpose, which makes our code unnecessarily complex.

Copy link
Collaborator

@chenmoneygithub chenmoneygithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments on the coding style, otherwise LGTM!

enable_network_access: Domains or IPs to allow network access in the sandbox.
enable_write_paths: Files or directories to allow writing to in the sandbox.
sync_files: If set, syncs changes within the sandbox back to original files after execution.
"""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessarily in this PR, but we should add some code examples to explain how to use these news args (also when should users use these args)

Copy link
Collaborator

@TomeHirata TomeHirata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnavsinghvi11 arnavsinghvi11 merged commit 5bc4a15 into main Jun 4, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants