-
Notifications
You must be signed in to change notification settings - Fork 1.9k
add more permission capabilities to PythonInterpreter #8296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice extension to PythonInterpreter! Left some comments.
Btw, I am working on a pure python-based code runner, as Pyodide is not really designed for this purpose, which makes our code unnecessarily complex.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments on the coding style, otherwise LGTM!
enable_network_access: Domains or IPs to allow network access in the sandbox. | ||
enable_write_paths: Files or directories to allow writing to in the sandbox. | ||
sync_files: If set, syncs changes within the sandbox back to original files after execution. | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessarily in this PR, but we should add some code examples to explain how to use these news args (also when should users use these args)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
improving the PythonInterpreter with higher permissions