Add docstring for dspy.ReAct #8334
Open
+36
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomeHirata
reviewed
Jun 6, 2025
dspy/predict/react.py
Outdated
|
|
||
| class ReAct(Module): | ||
| def __init__(self, signature, tools: list[Callable], max_iters=5): | ||
| def __init__(self, signature: Type["Signature"], tools: list[Callable], max_iters: Optional[int] = 5): |
There was a problem hiding this comment.
nit: no need to make the type of max_iters Optional since it has default value.
okhat
reviewed
Jun 6, 2025
| react = dspy.ReAct(signature="question->answer", tools=[get_weather]) | ||
|
|
||
| pred = react(question="What is the weather in Tokyo?") | ||
|
|
There was a problem hiding this comment.
Hmm why isn’t this example 3 lines. All the imports (esp Tool) and API key stuff is unnecessary
There was a problem hiding this comment.
Usually I prefer to have the code example fully runnable instead of assuming users already have the prerequisite knowledge, unless the full code is extremely long. For our new users, it may take a while to figure out all the setups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add docstring for dspy.ReAct.