-
-
Notifications
You must be signed in to change notification settings - Fork 839
feat: add math/base/special/cotd
#1772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
math/base/special/cotd
@Planeshifter should I add checks for when input is |
@Planeshifter this PR is ready for review. |
Signed-off-by: Sai Srikar Dumpeti <[email protected]>
lib/node_modules/@stdlib/math/base/special/cotd/docs/types/index.d.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some small change requests that hopefully will be easy to resolve.
Ready for merging otherwise, I think.
Co-authored-by: Philipp Burckhardt <[email protected]> Signed-off-by: Sai Srikar Dumpeti <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]> Signed-off-by: Sai Srikar Dumpeti <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]> Signed-off-by: Sai Srikar Dumpeti <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]> Signed-off-by: Sai Srikar Dumpeti <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]> Signed-off-by: Sai Srikar Dumpeti <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]> Signed-off-by: Sai Srikar Dumpeti <[email protected]>
…ex.d.ts Co-authored-by: Philipp Burckhardt <[email protected]> Signed-off-by: Sai Srikar Dumpeti <[email protected]>
@Planeshifter i have made the changes to this PR and others too. It is ready to be merged 🚀 |
Signed-off-by: Philipp Burckhardt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this one in as well; thanks!
@the-r3aper7 Same comment. Can you tick the box in the OP indicating that you've read the contributing guidelines? Thanks! |
Resolves #40
Description
This pull request:
Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers