fix: update hypotf to follow the IEEE 754-2019 standard
#6511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: passed
- task: lint_package_json
status: na
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: passed
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: na
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
stdlib-bot
added
Math
anandkaranubc
commented
Apr 2, 2025
| @@ -153,8 +167,11 @@ tape( 'the function computes the hypotenuse (canonical inputs)', opts, function | |||
| h = hypotf( 6.0, 8.0 ); | |||
| t.strictEqual( h, 10.0, 'returns expected value' ); | |||
|
|
|||
| // NOTE: the tolerance here is larger than for the JavaScript implementation due to compiler optimizations which may be performed resulting in result divergence. For discussion, see https://github.com/stdlib-js/stdlib/pull/2298#discussion_r1624765205 | |||
There was a problem hiding this comment.
Running it with
CFLAGS="-ffp-contract=off" make install-node-addons NODE_ADDONS_PATTERN="@stdlib/math/base/special/hypotf"
makes the test pass without any tolerance check.
There was a problem hiding this comment.
Oh, interesting. Thanks for tracking this down!
Coverage Report
The above coverage report was generated for the changes in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves None
Description
This pull request:
hypotfin compliance with IEEE 754-2019.Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers