Skip to content

feat: add C ndarray interface and refactor implementation for stats/base/dnanmskrange #7171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 4, 2025
Merged

feat: add C ndarray interface and refactor implementation for stats/base/dnanmskrange #7171

merged 10 commits into from
Jun 4, 2025

Conversation

gururaj1512
Copy link
Member

Resolves None

Description

What is the purpose of this pull request?

This pull request:

  • adds C ndarray interface for stats/base/dnanmskrange
  • refactors JavaScript implementation
  • refactors tests, docs, benchmarks and examples.

Related Issues

Does this pull request have any related issues?

This pull request:

  • None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@gururaj1512
feat: add C ndarray interface and refactor implementation for `stats/…
a019508 
…base/dnanmskrange`

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: missing_dependencies
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@gururaj1512
docs: update README
5506e7f
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jun 2, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jun 2, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dnanmskrange $\color{green}409/409$
$\color{green}+100.00\%$ 		$\color{green}31/31$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}409/409$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

gururaj1512
gururaj1512 commented Jun 2, 2025
View reviewed changes
@gururaj1512 gururaj1512 added GSoC Google Summer of Code. gsoc: 2025 Google Summer of Code (2025). labels Jun 2, 2025
kgryte added 2 commits June 2, 2025 15:41
@kgryte
docs: clean-up
98a24f2 
Signed-off-by: Athan <[email protected]>
@kgryte
docs: clean-up example
ed2d889 
Signed-off-by: Athan <[email protected]>
kgryte
kgryte reviewed Jun 2, 2025
View reviewed changes
kgryte
kgryte reviewed Jun 2, 2025
View reviewed changes
kgryte
kgryte reviewed Jun 2, 2025
View reviewed changes
kgryte
kgryte requested changes Jun 2, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the benchmarks, this is looking good.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jun 2, 2025
@gururaj1512
bench: update benchmarks
54ad16b 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@gururaj1512 gururaj1512 requested a review from kgryte June 3, 2025 07:52
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jun 3, 2025
@gururaj1512
Update dnanmskrange.js
e7c000e 
Signed-off-by: Gururaj Gurram <[email protected]>
@gururaj1512
Update README.md
896a908 
Signed-off-by: Gururaj Gurram <[email protected]>
@kgryte kgryte removed Needs Changes Pull request which needs changes before being merged. Needs Review A pull request which needs code review. labels Jun 4, 2025
kgryte
kgryte approved these changes Jun 4, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte merged commit c816e83 into stdlib-js:develop Jun 4, 2025
13 checks passed
@gururaj1512 gururaj1512 deleted the refactor-stats-base-dnanmskrange branch June 4, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
GSoC Google Summer of Code. gsoc: 2025 Google Summer of Code (2025). Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gururaj1512 @stdlib-bot @kgryte