[UPDATE] Add pre-commit hooks to catch linting issues #2098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| alreadyPresentHooks := make(map[string]bool) | ||
| for _, repos := range configMetadata.Repos { |
There was a problem hiding this comment.
When I run the test case locally, it fails off and on. This is because the order of repos in the output changes in a non-deterministic manner. range may return different order.
https://stackoverflow.com/questions/13744996/why-does-gos-map-iteration-order-vary-when-printing
https://stackoverflow.com/questions/18342784/how-to-iterate-through-a-map-in-golang-in-order
@Devils-Knight you will need to fix this in all places where range is used, and which may affect the order in the output file.
There was a problem hiding this comment.
Added the sorting code for repos returned so that the order of hooks retrieval is not affected by map iteration.
@varunsh-coder please review the fix, thank you.
varunsh-coder
pushed a commit
that referenced
this pull request
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@varunsh-coder please review the changes.