F4 GPIO #186
Draft
F4 GPIO #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burrbull
force-pushed
the
f4-gpio
branch
3 times, most recently
from
e122258 to
cd18012
Compare
Merged
Merged
burrbull
force-pushed
the
f4-gpio
branch
4 times, most recently
from
5b40c21 to
83e5b28
Compare
|
cc @usbalbin |
usbalbin
reviewed
Jun 10, 2025
Comment on lines
-34
to
+29
| _tx: TX, | ||
| _rx: RX, | ||
| pins: (impl Into<Self::Tx>, impl Into<Self::Rx>), |
There was a problem hiding this comment.
Why this change? Why a pair instead of two arguments?
usbalbin
reviewed
Jun 10, 2025
| pub struct Tx<USART: Instance, Dma, Otype = PushPull> { | ||
| pin: USART::Tx<Otype>, | ||
| pub struct Tx<USART: Instance, Dma = NoDMA, Otype = PushPull> { | ||
| pin: Option<USART::Tx<Otype>>, |
There was a problem hiding this comment.
This effectively makes this no longer a ZST? What is the advantage of the Option here as opposed to something like struct NoPin? Correct me if I am wrong but one disadvantage with Option is that you still have to specify the type even when passing None. That in my opinion defeats any ergonomics advantages vs just passing NoPin. Also there is not really any reduction in the amount of generic type parameters.
However I am still open to be convinced otherwise :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.