Skip to content

HardwareSerial: don't call STM32 HAL for every bytes to transfer #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2021
Merged

HardwareSerial: don't call STM32 HAL for every bytes to transfer #1313

merged 1 commit into from
Mar 10, 2021

Conversation

ABOSTM
Copy link
Contributor

@ABOSTM ABOSTM commented Mar 3, 2021

Summary

HardwareSerial: don't call STM32 HAL for every bytes to transfer

Instead of calling HAL for each and every bytes,
try to call it only once for a string.
Several call may be needed to manage internal circular buffer (tx_buff)

Fixes #1309

@ABOSTM ABOSTM added the enhancement New feature or request label Mar 3, 2021
@ABOSTM ABOSTM mentioned this pull request Mar 3, 2021
Closed
@ABOSTM ABOSTM requested a review from fpistm March 4, 2021 07:06
fpistm
fpistm requested changes Mar 9, 2021
View reviewed changes
@ABOSTM
HardwareSerial: don't call STM32 HAL for every bytes to transfer
9828c20 
Instead of calling HAL for each and every bytes,
try to call it only once for a string.
Several call may be needed to manage internal circular buffer
Fixes stm32duino#1309

Signed-off-by: Alexandre Bourdiol <[email protected]>
@ABOSTM ABOSTM force-pushed the HARDWARESERIAL_MULTI_CHAR_TRANSFER branch from d8a94e3 to 9828c20 Compare March 10, 2021 11:02
fpistm
fpistm approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpistm fpistm added this to the 2.0.0 milestone Mar 10, 2021
@fpistm fpistm merged commit 552a133 into stm32duino:master Mar 10, 2021
@ABOSTM
Copy link
Contributor Author

ABOSTM commented Mar 11, 2021

Performances measurements:
Note: This PR subserve, by implementation, sending multi char string instead of single char.
This is the major usage.

Tests performed with UART @115200

Test Before PR After PR Performance
Nucleo_l476RG
sending string of 20 char		 1,80 ms 1,72 ms gain: 4,4%
Nucleo_l476RG
sending 20 char one by one		 1,80 ms 1,88 ms loss: 4,4%
BluePill
sending string of 20 char		 1,90 ms 1,73 ms gain: 8,9%
BluePill
sending 20 char one by one		 1,90 ms 1,90 ms stable

ABOSTM added a commit to ABOSTM/Arduino_Core_STM32 that referenced this pull request Sep 22, 2021
@ABOSTM
HartdwareSerial: recover original Arduino asynchronous write API
333c3bd 
Avoid the waiting loop introduced with stm32duino#1313
Fixes stm32duino#1492

Signed-off-by: Alexandre Bourdiol <[email protected]>
@ABOSTM ABOSTM mentioned this pull request Sep 22, 2021
Merged
ABOSTM added a commit to ABOSTM/Arduino_Core_STM32 that referenced this pull request Sep 22, 2021
@ABOSTM
HartdwareSerial: recover original Arduino asynchronous write API
5a163e8 
Avoid the waiting loop introduced with stm32duino#1313
Fixes stm32duino#1492

Signed-off-by: Alexandre Bourdiol <[email protected]>
fpistm pushed a commit that referenced this pull request Sep 27, 2021
@ABOSTM
HartdwareSerial: recover original Arduino asynchronous write API (#1503)
9108857 
Avoid the waiting loop introduced with #1313
Fixes #1492

Signed-off-by: Alexandre Bourdiol <[email protected]>
@ABOSTM ABOSTM mentioned this pull request Mar 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpistm fpistm fpistm approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

STM32F1 UART TX idles after every byte
2 participants
@ABOSTM @fpistm