Support ssl and ssl_opts connection options
#14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ziinc @filipecabaco sorry to ping you, I was wondering if this PR could be reviewed. We have a change we are looking to merge into NervesHub (nerves-hub/nerves_hub_web#1151) and it would be great to not use my fork. p.s. such a god damn smart use of postgres for node discovery! |
|
@joshk could you add in some docs around the ssl options and example usage, as well as bump the patch version? |
|
Thanks for the quick reply @Ziinc Done! Let me know if you want something with extra detail. |
Ziinc
approved these changes
Dec 28, 2023
|
Awesome, thank you! |
|
@Ziinc Happy New Year! any chance of having this merged? |
|
hey! just a quick heads up that I'll review this one today. sorry for the delay 🙏 |
|
@filipecabaco thanks for the quick reply! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This adds support for the
sslandssl_optsPostgrex connection options.What is the current behavior?
If a custom SSL cert is required then the connection will fail.
What is the new behavior?
Custom SSL certs can now be configured and used.
Additional context
Crunchy Bridge provides customers their own SSL PEM, and SSL is enforced with all db connections. This PR addresses issues with SSL details not being passed to Postgrex.