-
Notifications
You must be signed in to change notification settings - Fork 42
feat: Add session claims feature #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KShivendu
commented
Jul 15, 2022
porcellus
requested changes
Jul 21, 2022
supertokens_python/recipe/session/claim_base_classes/primitive_claim.py
Outdated
Show resolved
Hide resolved
supertokens_python/recipe/session/framework/django/asyncio/__init__.py
Outdated
Show resolved
Hide resolved
porcellus
requested changes
Jul 21, 2022
rishabhpoddar
suggested changes
Jul 28, 2022
supertokens_python/recipe/session/claim_base_classes/primitive_claim.py
Outdated
Show resolved
Hide resolved
supertokens_python/recipe/session/claim_base_classes/primitive_claim.py
Outdated
Show resolved
Hide resolved
supertokens_python/recipe/session/claim_base_classes/primitive_claim.py
Outdated
Show resolved
Hide resolved
supertokens_python/recipe/session/claim_base_classes/primitive_claim.py
Outdated
Show resolved
Hide resolved
supertokens_python/recipe/session/with_jwt/recipe_implementation.py
Outdated
Show resolved
Hide resolved
supertokens_python/recipe/session/claim_base_classes/primitive_claim.py
Outdated
Show resolved
Hide resolved
supertokens_python/recipe/session/claim_base_classes/primitive_claim.py
Outdated
Show resolved
Hide resolved
rishabhpoddar
suggested changes
Sep 7, 2022
rishabhpoddar
suggested changes
Sep 10, 2022
rishabhpoddar
suggested changes
Sep 11, 2022
… invalid claim handler
feat(session): Review based changes
feat: Session claims (test+changelog+example)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
Add session claims features
NOTE: The PR is only partially complete so please expect things to be not perfect (eg. non implemented classes like
BooleanClaim
).Related issues
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
coreDriverInterfaceSupported.json
file has been updated (if needed)supertokens_python/constants.py
frontendDriverInterfaceSupported.json
file has been updated (if needed)setup.py
supertokens_python/constants.py
git tag
) in the formatvX.Y.Z
, and then find the latest branch (git branch --all
) whoseX.Y
is greater than the latest released tag.supertokens_python/utils.py
file to include that in theFRAMEWORKS
variableTODO
Things that need to be done on top of this PR:
resetPasswordUsingTokenFeature. getResetPasswordURL
config from emailpassword recipe: https://github.com/supertokens/supertokens-node/pull/278/files#diff-089164338b0969ed3d7cd24df7019a7d11d05846bf08cb47f671f0bc2bae64eeL69get_session
function (from APIs for sign out, or email verification APIs to return an empty array for overrideGlobalClaimValidatorsPostSuperTokensInitCallbacks
class and use it in recipes where relevant.