-
Notifications
You must be signed in to change notification settings - Fork 42
feat: Add and use email verification claim #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
a7e4b6a
feat: Add and use email verification claim
KShivendu 918e15f
feat: Add and use email verification claim
KShivendu 07fe952
fix: Fix lint errors and make email verification claims usable
KShivendu 29d7cee
refactor: Use email veriifcation claim in thirdparty recipe
KShivendu 6957000
refactor: Run black on tp recipe and use ev claim in pless recipe
KShivendu 44d0f3a
refactor: Remove email verification features from thirdpartyemailpass…
KShivendu 720f593
refactor: Remove email verification features from thirdpartypasswordl…
KShivendu e31b60d
refactor: Clean up usages of email verification in other recipes in f…
KShivendu 0834fe5
refactor: Fix circular dependency error in emailverification recipe a…
KShivendu 34e492a
test: Fix test failures related to tpep recipe
KShivendu 1586251
refactor: Allow emailverification init without directly using ParentR…
KShivendu 10395c4
tests: Fix test failures in tppless email delivery
KShivendu 27282d4
changes based on feedback
KShivendu 3df9f16
Remove get_link_domain_and_path function and ev logic from other recipes
KShivendu 63eb59b
Merge branch 'feat/session-grants' into feat/ev-claim
KShivendu 619ac25
feat: Changes suggested in feedback
KShivendu 5b36b16
refactor: Remove ParentRecipeEmailVerificationConfig
KShivendu 01c2609
test: Fix failing tests
KShivendu 6fc90c6
refactor: Remove irrelevant comment
KShivendu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
from typing import Callable, List | ||
|
||
|
||
class PostSTInitCallbacks: | ||
"""Callbacks that are called after the SuperTokens instance is initialized.""" | ||
|
||
callbacks: List[Callable[[], None]] = [] | ||
|
||
@staticmethod | ||
def add_post_init_callback(cb: Callable[[], None]) -> None: | ||
PostSTInitCallbacks.callbacks.append(cb) | ||
|
||
@staticmethod | ||
def run_post_init_callbacks() -> None: | ||
for cb in PostSTInitCallbacks.callbacks: | ||
cb() | ||
|
||
PostSTInitCallbacks.callbacks = [] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 changes: 0 additions & 49 deletions
49
...d/emaildelivery/services/smtp/service_implementation/email_verification_implementation.py
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to also modify the
get_content
function below -> how come pyright did not complain about the unnecessary check ofif isinstance(template_vars, VerificationEmailTemplateVars):
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.