Skip to content

test: Ensure that override work as expected for Session Container methods #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

KShivendu
Copy link
Contributor

@KShivendu KShivendu commented Aug 16, 2022

Summary of change

test: Ensure that override work as expected for Session Container methods

Related issues

  • Link to issue1 here
  • Link to issue1 here

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens_python/constants.py
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In setup.py
    • In supertokens_python/constants.py
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the supertokens_python/utils.py file to include that in the FRAMEWORKS variable
  • If added a new recipe that has a User type with extra info, then be sure to change the User type in supertokens_python/types.py

@KShivendu KShivendu changed the base branch from master to 0.10 August 16, 2022 04:31
@KShivendu KShivendu self-assigned this Aug 16, 2022
@KShivendu KShivendu closed this Aug 17, 2022
@rishabhpoddar rishabhpoddar reopened this Aug 17, 2022
@KShivendu KShivendu force-pushed the fix/session-container branch from b887e17 to 2624cde Compare August 17, 2022 06:41
@KShivendu KShivendu changed the title fix: Overrides not applying correctly in methods called on Session Container test: Ensure that override work as expected for Session Container methods Aug 17, 2022
@rishabhpoddar rishabhpoddar merged commit a7b2198 into 0.10 Aug 17, 2022
@rishabhpoddar rishabhpoddar deleted the fix/session-container branch August 17, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants