Skip to content

feat: Add User ID Mapping feature #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 30, 2022
Merged

Conversation

KShivendu
Copy link
Contributor

@KShivendu KShivendu commented Aug 18, 2022

Summary of change

feat: Add User ID Mapping feature (without creating new recipe)

Note: I'm intentionally not testing that all the recipes function are returning External User ID because of these three reasons:

  • I haven't touched anything in the existing recipes folders (emailpassword, passwordless, etc)
  • SuperTokens Core already has tests to ensure that it returns External User ID when provided
  • The node sdk already tests all of them..

Doing so would be redundant with no ROI.

Related issues

  • Link to issue1 here
  • Link to issue1 here

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens_python/constants.py
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In setup.py
    • In supertokens_python/constants.py
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the supertokens_python/utils.py file to include that in the FRAMEWORKS variable
  • If added a new recipe that has a User type with extra info, then be sure to change the User type in supertokens_python/types.py

@KShivendu KShivendu mentioned this pull request Aug 18, 2022
8 tasks
@KShivendu KShivendu changed the title feat: Add User ID Mapping feature feat: Add User ID Mapping feature Aug 30, 2022
@KShivendu KShivendu changed the title feat: Add User ID Mapping feature feat: Add User ID Mapping featurg Aug 30, 2022
@KShivendu KShivendu changed the title feat: Add User ID Mapping featurg feat: Add User ID Mapping feature Aug 30, 2022
@rishabhpoddar rishabhpoddar merged commit b6896b3 into 0.10 Aug 30, 2022
@rishabhpoddar rishabhpoddar deleted the feat/user-id-mapping-new branch August 30, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants