-
Notifications
You must be signed in to change notification settings - Fork 42
feat: Api logic implementation #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Api logic implementation #291
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good enough for the first time. I left some comments please check if those mistakes are repeated elsewhere in the code :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropped some more comments. Please validate the changes with the corresponding Node PR. Also, remember to manually test the flow at least once.
"Neither 'API Key' nor 'Authorization' header was found" | ||
) | ||
sessionIdFormAuthHeader = sessionIdFormAuthHeader.split()[1] | ||
await Querier.get_instance().send_delete_request( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs an equivalent of sessionDeleteResponse
.
Summary of change
Email password login for dashboard recipe
Related issues
supertokens/dashboard#55
Test Plan
All existing tests pass
Documentation changes
None
Checklist for important updates
coreDriverInterfaceSupported.json
file has been updated (if needed)supertokens_python/constants.py
frontendDriverInterfaceSupported.json
file has been updated (if needed)setup.py
supertokens_python/constants.py
git tag
) in the formatvX.Y.Z
, and then find the latest branch (git branch --all
) whoseX.Y
is greater than the latest released tag.supertokens_python/utils.py
file to include that in theFRAMEWORKS
variableRemaining TODOs for this PR