Skip to content

feat: Api logic implementation #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Mar 7, 2023

Conversation

iresharma
Copy link
Contributor

Summary of change

Email password login for dashboard recipe

Related issues

supertokens/dashboard#55

Test Plan

All existing tests pass

Documentation changes

None

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens_python/constants.py
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In setup.py
    • In supertokens_python/constants.py
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the supertokens_python/utils.py file to include that in the FRAMEWORKS variable
  • If added a new recipe that has a User type with extra info, then be sure to change the User type in supertokens_python/types.py

Remaining TODOs for this PR

@iresharma iresharma changed the base branch from interface-changes to email-password-feature-branch February 27, 2023 12:05
@iresharma iresharma requested a review from KShivendu March 1, 2023 06:45
Copy link
Contributor

@KShivendu KShivendu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough for the first time. I left some comments please check if those mistakes are repeated elsewhere in the code :)

Copy link
Contributor

@KShivendu KShivendu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped some more comments. Please validate the changes with the corresponding Node PR. Also, remember to manually test the flow at least once.

"Neither 'API Key' nor 'Authorization' header was found"
)
sessionIdFormAuthHeader = sessionIdFormAuthHeader.split()[1]
await Querier.get_instance().send_delete_request(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs an equivalent of sessionDeleteResponse.

@nkshah2 nkshah2 merged commit a25bc40 into email-password-feature-branch Mar 7, 2023
@nkshah2 nkshah2 deleted the api-logic-implementation branch March 7, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants