fix: Improvements in session jwt changes #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porcellus
requested changes
Apr 28, 2023
rishabhpoddar
suggested changes
Apr 28, 2023
KShivendu
commented
May 2, 2023
| access_token_updated = False | ||
|
|
||
| session = Session( | ||
| self, | ||
| self.config, | ||
| access_token_str, | ||
| build_front_token(response["session"]["userId"], expiry_time, payload), | ||
| # FIXME: expiry time cannot be None |
There was a problem hiding this comment.
Fix after @porcellus concludes what should be done (and maybe updates node SDK)
There was a problem hiding this comment.
There was a problem hiding this comment.
The fixme comment is still left I think
porcellus
requested changes
May 3, 2023
| access_token_updated = False | ||
|
|
||
| session = Session( | ||
| self, | ||
| self.config, | ||
| access_token_str, | ||
| build_front_token(response["session"]["userId"], expiry_time, payload), | ||
| # FIXME: expiry time cannot be None |
There was a problem hiding this comment.
porcellus
requested changes
May 4, 2023
porcellus
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
Improvements in session jwt changes
Checklist for important updates
coreDriverInterfaceSupported.jsonfile has been updated (if needed)supertokens_python/constants.pyfrontendDriverInterfaceSupported.jsonfile has been updated (if needed)setup.pysupertokens_python/constants.pygit tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.supertokens_python/utils.pyfile to include that in theFRAMEWORKSvariable