Skip to content

feat: Add a helper function to read the original request from the user context inside overrides #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 23, 2023

Conversation

nkshah2
Copy link
Contributor

@nkshah2 nkshah2 commented May 23, 2023

Summary of change

  • Added a helper function exported by the SuperTokens class that makes it easier to get the original request from the user context
  • This reduces the boilerplate of always having to use usercontext._default.request and also allows the request to be strongly typed

Related issues

Test Plan

Added a test to make sure the new function works correctly

Documentation changes

WIP

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens_python/constants.py
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In setup.py
    • In supertokens_python/constants.py
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the supertokens_python/utils.py file to include that in the FRAMEWORKS variable
  • If added a new recipe that has a User type with extra info, then be sure to change the User type in supertokens_python/types.py
  • Make sure that syncio / asyncio functions are consistent.

Remaining TODOs for this PR

  • ...

@nkshah2 nkshah2 requested a review from rishabhpoddar May 23, 2023 10:38
@@ -103,3 +104,9 @@ def update_or_delete_user_id_mapping_info(
user_id, user_id_type, external_user_id_info
)
)


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put in __init file itself

@@ -277,3 +278,113 @@ async def create_new_session(
create_new_session_context_works,
]
)


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make test better

@rishabhpoddar rishabhpoddar merged commit f3e6bb2 into 0.14 May 23, 2023
@rishabhpoddar rishabhpoddar deleted the feat/usercontext-request-helper branch May 23, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants