Skip to content

test: Verify session should return 401 if access token isn't sent and middleware isn't added #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 7, 2023

Conversation

KShivendu
Copy link
Contributor

@KShivendu KShivendu commented Jul 3, 2023

Summary of change

Verify session should return 401 if not access token is sent and middelware isn't added. This PR adds a test for that.

Updated FastAPI and Flask. Django was already handling this.

Related issues

  • Link to issue1 here
  • Link to issue1 here

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens_python/constants.py
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In setup.py
    • In supertokens_python/constants.py
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the supertokens_python/utils.py file to include that in the FRAMEWORKS variable
  • If added a new recipe that has a User type with extra info, then be sure to change the User type in supertokens_python/types.py
  • Make sure that syncio / asyncio functions are consistent.

@KShivendu KShivendu changed the title test: Verify session should return 401 if not access token is sent and middelware isn't added test: Verify session should return 401 if access token isn't sent and middelware isn't added Jul 3, 2023
@KShivendu KShivendu changed the title test: Verify session should return 401 if access token isn't sent and middelware isn't added test: Verify session should return 401 if access token isn't sent and middleware isn't added Jul 3, 2023

return func


async def st_exception_handler(request: Request, exc: SuperTokensError) -> JSONResponse:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
async def st_exception_handler(request: Request, exc: SuperTokensError) -> JSONResponse:
async def session_exception_handler(request: Request, exc: SuperTokensError) -> JSONResponse:

@@ -11,11 +11,18 @@
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
import json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modify changelog. No need to change patch version though.

@rishabhpoddar rishabhpoddar merged commit d37809c into 0.14 Jul 7, 2023
@rishabhpoddar rishabhpoddar deleted the test/verify-session-if-no-middleware branch July 7, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants