Skip to content

fix: Linters errors and format #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 11, 2023
Merged

Conversation

KShivendu
Copy link
Contributor

@KShivendu KShivendu commented Jul 6, 2023

Summary of change

Fix linter errors and format

Related issues

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens_python/constants.py
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In setup.py
    • In supertokens_python/constants.py
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the supertokens_python/utils.py file to include that in the FRAMEWORKS variable
  • If added a new recipe that has a User type with extra info, then be sure to change the User type in supertokens_python/types.py
  • Make sure that syncio / asyncio functions are consistent.

Remaining TODOs for this PR

  • Fix apple provider in the example.

Comment on lines 15 to 33
from .apple import Apple
from .discord import Discord
from .facebook import Facebook
from .github import Github
from .google import Google
from .google_workspaces import GoogleWorkspaces
from .bitbucket import Bitbucket
from .gitlab import Gitlab

__all__ = [
"Apple",
"Discord",
"Facebook",
"Github",
"Google",
"GoogleWorkspaces",
"Bitbucket",
"Gitlab",
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this whole thing

@rishabhpoddar rishabhpoddar merged commit 53b7710 into feat/tp-rework Jul 11, 2023
@rishabhpoddar rishabhpoddar deleted the fix/linter-errors branch July 11, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants