feat: Session recipe multitenancy changes #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabhpoddar
suggested changes
Jul 30, 2023
rishabhpoddar
suggested changes
Aug 3, 2023
Comment on lines
26
to
28
| # TODO: Pass tenant id here | ||
| session_handles = await get_all_session_handles_for_user( | ||
| user_id, "pass-tenant-id", user_context |
There was a problem hiding this comment.
this won't have tenant id passed to it. You need to pass None to it instead so that it gets all session's for the user across all the tenants. See node PR
| self, | ||
| user_id: str, | ||
| tenant_id: str, | ||
| revoke_across_all_tenants: Optional[bool], |
There was a problem hiding this comment.
this should not be optional in recipe interface
| self, | ||
| user_id: str, | ||
| tenant_id: str, | ||
| fetch_across_all_tenants: Optional[bool], |
There was a problem hiding this comment.
this should not be optional in recipe interface
rishabhpoddar
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
Session recipe multitenancy changes
Issues:
Checklist for important updates
coreDriverInterfaceSupported.jsonfile has been updated (if needed)supertokens_python/constants.pyfrontendDriverInterfaceSupported.jsonfile has been updated (if needed)setup.pysupertokens_python/constants.pygit tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.supertokens_python/utils.pyfile to include that in theFRAMEWORKSvariablesyncio/asynciofunctions are consistent.