Skip to content

fix: Set tenant_id as None by default in ep and userroles functions #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

KShivendu
Copy link
Contributor

@KShivendu KShivendu commented Aug 4, 2023

Summary of change

Set tenant_id as None by default in ep and userroles functions

Related issues

No related issue. This is important to have a good DX for python devs, keep them consistent with other recipes (and modify fewer tests related to these recipes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens_python/constants.py
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In setup.py
    • In supertokens_python/constants.py
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the supertokens_python/utils.py file to include that in the FRAMEWORKS variable
  • If added a new recipe that has a User type with extra info, then be sure to change the User type in supertokens_python/types.py
  • Make sure that syncio / asyncio functions are consistent.

Base automatically changed from fix/mt-dashboard to feat/tp-rework August 8, 2023 17:26
@KShivendu KShivendu merged commit f062633 into feat/tp-rework Aug 9, 2023
@KShivendu KShivendu deleted the fix/ep-userroles-tenantid branch August 9, 2023 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants