Skip to content

fix: Multitenancy tests for all the recipes #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 10, 2023

Conversation

KShivendu
Copy link
Contributor

@KShivendu KShivendu commented Aug 8, 2023

Summary of change

Fix failures in Multitenancy tests for all the recipes.

Related issues

  • Link to issue1 here
  • Link to issue1 here

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens_python/constants.py
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In setup.py
    • In supertokens_python/constants.py
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the supertokens_python/utils.py file to include that in the FRAMEWORKS variable
  • If added a new recipe that has a User type with extra info, then be sure to change the User type in supertokens_python/types.py
  • Make sure that syncio / asyncio functions are consistent.

Base automatically changed from fix/thirdparty-config-mt to feat/tp-rework August 9, 2023 07:19
@KShivendu KShivendu changed the title fix: Multitenancy tests for userroles, thirdparty, and emailpassword fix: Multitenancy tests for all the recipes Aug 9, 2023
@KShivendu
Copy link
Contributor Author

KShivendu commented Aug 9, 2023

@rishabhpoddar there's just one last test that's failing. I fixed others:

See

result.session.handle == session_handles[i]

It generates 7 sessions and expects session handles to remain same when regenerate_access_token is used.

Original set of session handles:

0: '70e6ea04-2471-4365-acd6-3968bd8a139d'
1: '786b611d-d93c-45bb-bfcd-04bfd0da987b'
2: '9b2f950b-bd9f-45bc-a9dd-f2d1d6c1f5d6'
3: 'a60e42c5-25bc-41cc-9b0c-e4f1c0eff1c9'
4: 'bb7bce5a-34bd-4c4b-8a2e-261d640aef74'
5: 'c6627557-962f-4203-bbcc-47fc5c57bc8f'
6: 'cc958019-fb96-42df-89e2-da1b18a1f222'

New session handle for 0th index returned by regenerate_access_token :

9b2f950b-bd9f-45bc-a9dd-f2d1d6c1f5d6

It expected this one at the 0th index but for some reason, it's actually matching with handle at the 2nd index. That's why the test fails. What should we do? What could be causing this from the code side?

You may also check out the test failure logs at https://github.com/supertokens/supertokens-python/actions/runs/5809718427/job/15749060661#step:15:525

@rishabhpoddar rishabhpoddar merged commit bd91b74 into feat/tp-rework Aug 10, 2023
@rishabhpoddar rishabhpoddar deleted the fix/multitenancy-recipe-tests branch August 10, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants