Skip to content

feat!: appinfo refactor #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 43 commits into from
Nov 28, 2023
Merged

feat!: appinfo refactor #459

merged 43 commits into from
Nov 28, 2023

Conversation

IamMayankThakur
Copy link
Contributor

@IamMayankThakur IamMayankThakur commented Nov 14, 2023

Summary of change

  • Adds support for configuring multiple frontend domains to be used with the same backend
  • Added new origin property to InputAppInfo, this can be configured to conditionally return the value of the frontend domain.
  • website_domain inside InputAppInfo is now optional. Using website_domain will continue to work.

Related issues

Test Plan

Added unit tests

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens_python/constants.py
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In setup.py
    • In supertokens_python/constants.py
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the supertokens_python/utils.py file to include that in the FRAMEWORKS variable
  • If added a new recipe that has a User type with extra info, then be sure to change the User type in supertokens_python/types.py
  • Make sure that syncio / asyncio functions are consistent.
  • If access token structure has changed
    • Modified test in tests/sessions/test_access_token_version.py to account for any new claims that are optional or omitted by the core

Remaining TODOs for this PR

  • Item1
  • Item2

@IamMayankThakur IamMayankThakur changed the base branch from 0.16 to 0.17 November 24, 2023 07:16
@IamMayankThakur IamMayankThakur changed the title Feat/appinfo refactor feat!: appinfo refactor Nov 27, 2023
@IamMayankThakur IamMayankThakur changed the base branch from 0.17 to 0.18 November 27, 2023 06:39
@IamMayankThakur IamMayankThakur marked this pull request as ready for review November 27, 2023 06:45
@rishabhpoddar rishabhpoddar merged commit 6295c4b into 0.18 Nov 28, 2023
@rishabhpoddar rishabhpoddar deleted the feat/appinfo-refactor branch November 28, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants