Skip to content

fix: LinkedIn OAuth #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2023
Merged

fix: LinkedIn OAuth #462

merged 1 commit into from
Dec 5, 2023

Conversation

anku255
Copy link
Contributor

@anku255 anku255 commented Dec 5, 2023

Summary of change

This PR updates the LinkedIn OAuth implementation as per the recent changes.

Test Plan

Tested manually

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens_python/constants.py
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In setup.py
    • In supertokens_python/constants.py
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the supertokens_python/utils.py file to include that in the FRAMEWORKS variable
  • If added a new recipe that has a User type with extra info, then be sure to change the User type in supertokens_python/types.py
  • Make sure that syncio / asyncio functions are consistent.
  • If access token structure has changed
    • Modified test in tests/sessions/test_access_token_version.py to account for any new claims that are optional or omitted by the core

@anku255 anku255 changed the base branch from master to 0.18 December 5, 2023 14:06
@anku255 anku255 force-pushed the fix/linkedin-oauth branch from b09d4e4 to 7ac3e02 Compare December 5, 2023 14:19
@rishabhpoddar rishabhpoddar merged commit adf45cf into 0.18 Dec 5, 2023
@rishabhpoddar rishabhpoddar deleted the fix/linkedin-oauth branch December 5, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants