Skip to content

Remove combination recipe/base #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 24, 2024
Merged

Conversation

rishabhpoddar
Copy link
Contributor

@rishabhpoddar rishabhpoddar commented Apr 26, 2024

Summary of change

Removing of combination recipe

Related issues

Test Plan

TODO

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens_python/constants.py
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In setup.py
    • In supertokens_python/constants.py
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the supertokens_python/utils.py file to include that in the FRAMEWORKS variable
  • If added a new recipe that has a User type with extra info, then be sure to change the User type in supertokens_python/types.py
  • Make sure that syncio / asyncio functions are consistent.
  • If access token structure has changed
    • Modified test in tests/sessions/test_access_token_version.py to account for any new claims that are optional or omitted by the core

Remaining TODOs for this PR

  • Search for all places for thirdpartyemailpassword and thirdpartypasswordless and make sure they don't exist
  • Test dashboard
  • if input rid is tpep, or tpless, it should try and map to the the right breakup
  • Add test for checking rid based on tpep and tpless
  • remove rid from links generated by the sdk
  • example app updates

@rishabhpoddar rishabhpoddar changed the base branch from 0.17 to 0.18 April 26, 2024 08:03
@rishabhpoddar rishabhpoddar changed the base branch from 0.18 to 0.20 May 23, 2024 07:07
@rishabhpoddar rishabhpoddar changed the base branch from 0.20 to 0.21 May 24, 2024 05:46
@rishabhpoddar rishabhpoddar marked this pull request as ready for review May 24, 2024 05:46
@rishabhpoddar rishabhpoddar merged commit 19c0f29 into 0.21 May 24, 2024
4 of 8 checks passed
@rishabhpoddar rishabhpoddar deleted the remove-combination-recipe/base branch May 24, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant