Skip to content

fix: reverts cookie timezones to GMT #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025
Merged

fix: reverts cookie timezones to GMT #587

merged 1 commit into from
May 20, 2025

Conversation

namsnath
Copy link
Contributor

Summary of change

  • Fixes cookies being set without expiry in Django
    • Reverts timezone change from 0.28.0 and uses GMT

Related issues

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens_python/constants.py
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In setup.py
    • In supertokens_python/constants.py
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the supertokens_python/utils.py file to include that in the FRAMEWORKS variable
  • If added a new recipe that has a User type with extra info, then be sure to change the User type in supertokens_python/types.py
  • Make sure that syncio / asyncio functions are consistent.
  • If access token structure has changed
    • Modified test in tests/sessions/test_access_token_version.py to account for any new claims that are optional or omitted by the core

Remaining TODOs for this PR

Copy link

promptless bot commented May 19, 2025

📝 Documentation updates detected! You can review documentation updates here

@namsnath namsnath force-pushed the fix/cookie_timezone branch from 4966c71 to 32ee6e3 Compare May 19, 2025 06:43
@namsnath namsnath requested a review from porcellus May 19, 2025 09:02
@namsnath namsnath self-assigned this May 19, 2025
@namsnath namsnath merged commit 187d6ff into 0.29 May 20, 2025
1576 checks passed
@namsnath namsnath deleted the fix/cookie_timezone branch May 20, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants