-
-
Notifications
You must be signed in to change notification settings - Fork 43
fix: properly log error when dependency install fails #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: d69760c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, and probably it's just my testing that is flawed.
I created a project, edit one package inside package.json
to a non existing version and executed this pr. It's still not printing anything.
Executing pnpm install
by hand brings the following output with exit code 1
Output
ERR_PNPM_NO_MATCHING_VERSION No matching version found for @sveltejs/adapter-auto@^30.0.0
This error happened while installing a direct dependency of D:\dev\web\svelte-cli-temp
The latest release of @sveltejs/adapter-auto is "3.3.1".
Other releases are:
* next: 1.0.0-next.91
If you need the full list of all 113 published versions run "$ pnpm view @sveltejs/adapter-auto versions".
Progress: resolved 12, reused 12, downloaded 0, added 0
I'm assuming this is technically a pnpm error for not printing to stderr
, but we probably should care about both.
Yea, I think this is a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested this again with npm
and everything works as expected there.
closes #227