Skip to content

chore: remove routify #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 29, 2024
Merged

chore: remove routify #252

merged 3 commits into from
Oct 29, 2024

Conversation

manuel3108
Copy link
Member

As we decided to ditch #32 for an upcoming more flexible PR, we should remove routify separately.
Reasoning: Routify is nearly unused on npm, and we do recommend creating full kit applications

Copy link

changeset-bot bot commented Oct 29, 2024

🦋 Changeset detected

Latest commit: 59666a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Oct 29, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/sveltejs/cli/sv@252

commit: 59666a9

@benmccann
Copy link
Member

we can remove the svelte environment now as this was the only one that wouldn't run in a kit project

@manuel3108
Copy link
Member Author

Do you mean completely removing the svelte property, or completely removing the environment property?

@manuel3108
Copy link
Member Author

But that's actually not true, tailwindcss can still be added to a svelte project in example

@AdrianGonz97
Copy link
Member

AdrianGonz97 commented Oct 29, 2024

We can just have the kit field where it indicates that SvelteKit is required. if kit === true and we're not in a SvelteKit project, then the precondition error is thrown.

In the case of tailwind, kit will be false, so it should work in all places

@manuel3108
Copy link
Member Author

Should this still be an object while we are going to be refactoring that? Can we think of any other environments that might appear in the future?

Should we rename kit to requiresKit to make things more clear?

@AdrianGonz97
Copy link
Member

Maybe we should just get rid of the field entirely and add a setup hook as part of #181? I don't think we should be blocking this PR from merging as we can address this separately.

@benmccann
Copy link
Member

Yeah, I was talking about the svelte environment, which has always felt weird to me because everything is a svelte project. Maybe we should just rename that one to vite instead?

Can we think of any other environments that might appear in the future?

vite would probably be the main one. Like I bet the Tailwind adder isn't actually a svelte adder, but is a vite adder. Probably if you tried to set it up in a webpack project it doesn't work because you need postcss setup correctly

@benmccann
Copy link
Member

yeah, it doesn't have to block this PR

I'd thought about the setup hook too. The trade-off there is that a hook is more flexible, but can't be displayed easily via a website directory

@manuel3108
Copy link
Member Author

But kit project are also using vite.

setup hooks sounds fine, and aligns with our goal of a more flexible api. But let's implement this in #181

@manuel3108 manuel3108 merged commit b34d80e into main Oct 29, 2024
5 checks passed
@manuel3108 manuel3108 deleted the chore/remove-routify branch October 29, 2024 17:22
@github-actions github-actions bot mentioned this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants