Skip to content

fix: update svelte-eslint-parser to fix nested {#snippet} #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2024
Merged

fix: update svelte-eslint-parser to fix nested {#snippet} #805

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38b340e
update
baseballyama Jun 23, 2024
f282044
add env
baseballyama Jun 23, 2024
4f7a007
revert NodeCI
baseballyama Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/silver-walls-retire.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'eslint-plugin-svelte': patch
---

fix: update `svelte-eslint-parser` to fix nested `{#snippet}`
4 changes: 3 additions & 1 deletion .github/workflows/NodeCI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,9 @@ jobs:
run: pnpm install -D -w eslint@${{ matrix.eslint }}

- name: Test
run: pnpm test
run: |
export NODE_OPTIONS="--max-old-space-size=8192"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect this workaround will no longer be necessary once v5.0.0-165 is released.

pnpm test
working-directory: ${{ env.project_root_path }}

test-for-svelte-v4:
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-plugin-svelte/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
"postcss-safe-parser": "^6.0.0",
"postcss-selector-parser": "^6.1.0",
"semver": "^7.6.2",
"svelte-eslint-parser": "^0.39.1"
"svelte-eslint-parser": "^0.39.2"
},
"devDependencies": {
"@babel/core": "^7.24.7",
Expand Down
Loading