Skip to content

style: sidebar spacing idea #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

huntabyte
Copy link
Member

This gives the individual nav items just a wee bit of padding on the y-axis (0.15rem) and reduces the spacing between the sections by 0.5rem. Feels a bit less squished. Just an idea!

Before:
CleanShot 2024-10-18 at 19 03 16@2x

After:
CleanShot 2024-10-18 at 19 04 09@2x

Copy link

vercel bot commented Oct 18, 2024

@huntabyte is attempting to deploy a commit to the Svelte team on Vercel, but is not a member of this team. To resolve this issue, you can:

  • Make your repository public. Collaboration is free for open source and public repositories.
  • Add @huntabyte as a member. A Pro subscription is required to access Vercel's collaborative features.
    • If you're the owner of the team, click here and add @huntabyte as a member.
    • If you're the user who initiated this build request, click here to request access.
    • If you're already a member of the Svelte team, make sure that your Vercel account is connected to your GitHub account.

To read more about collaboration on Vercel, click here.

@Rich-Harris
Copy link
Member

Hmm, I'm not sure about this change. Adding padding to a is equivalent to changing the line height, and if there's one rules I've learned to trust in typography it's 'don't fuck with line height'. We use 1.5 consistently everywhere with this font, and if we start to add exceptions it will begin to look disjointed. I'm also just not sure that it's needed — I think low information density is one of the sins of modern web design.

As for the 3.5rem: this isn't exactly codified anywhere (it would be extremely generous to call what we have right now a 'design system') but a lot of the spacing on the site is 1rem, 2rem, 4rem... again I think things will be more harmonious overall if we try and stick to a small set of lengths rather than nudging it on an ad hoc basis

@huntabyte
Copy link
Member Author

Hmm, I'm not sure about this change. Adding padding to a is equivalent to changing the line height, and if there's one rules I've learned to trust in typography it's 'don't fuck with line height'. We use 1.5 consistently everywhere with this font, and if we start to add exceptions it will begin to look disjointed. I'm also just not sure that it's needed — I think low information density is one of the sins of modern web design.

As for the 3.5rem: this isn't exactly codified anywhere (it would be extremely generous to call what we have right now a 'design system') but a lot of the spacing on the site is 1rem, 2rem, 4rem... again I think things will be more harmonious overall if we try and stick to a small set of lengths rather than nudging it on an ad hoc basis

Copy all! I felt weird about the 3.5 but 2 felt cramped and 4 made the overflow scroll a bit longer with the extra item spacing. I'll go ahead and close this!

@huntabyte huntabyte closed this Oct 19, 2024
@dummdidumm dummdidumm deleted the huntabyte/nav-spacing-idea branch October 19, 2024 05:42
@Rich-Harris Rich-Harris mentioned this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants