Skip to content

order contributors #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2024
Merged

order contributors #723

merged 2 commits into from
Oct 30, 2024

Conversation

Rich-Harris
Copy link
Member

this absolute monstrosity — which I did by hand — orders contributors and donors by number of commits/size of donation. I mostly did it as a fun CSS puzzle but if we like it we can keep it. (also if anyone has a smarter idea for how to do this I am all ears)

closes #372

@Conduitry
Copy link
Member

jesus

Copy link
Collaborator

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both shocked that you got this working and also perplexed by how complicated it was!

@dummdidumm
Copy link
Member

wow 😄 Honestly I'm not sure if we want to keep that, because of the additional CSS - seems quite big.

Is there like a middle ground we can take?

Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 4:53pm

@Rich-Harris
Copy link
Member Author

We can't know the exact impact until it's deployed, because for whatever reason the compression seems very slightly different between prod and preview deployments. But: the .css file that's affected by this change goes from 3.01kb transferred on main to 3.94kb on this branch, and with the apparently-more-effective prod compression that delta will likely go down to below 0.9kb. In other words it's basically free and we probably should make the decision based on whether we think it's a good change rather than how costly it is

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving in that case

@Rich-Harris Rich-Harris merged commit 0eb5659 into main Oct 30, 2024
5 checks passed
@Rich-Harris Rich-Harris deleted the order-contributors branch October 30, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put top contributors/donors in center
4 participants