More token tweaks #751
Merged
More token tweaks #751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While you have the "where should X apply" in your head, we should write that into the CSS token files as comments, so that we don't regress in the future or someone new is scratching their head what token to use for a certain UI. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Done. Will merge to unblock the next phase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the work towards overhauling our
--sk-bg-ntokens (#707 (comment)):--sk-border-mediumto--sk-border. This should be used by default for all borders unless there's a compelling reason to do something different--sk-border-lightand-darkto-highlightand-shadow, to differentiate from theme terminology. These are used on the edges of buttons to give them a raised appearance, and preferably nowhere else--sk-bg-5colour altogether. This was only used in one place that wasn't a border — the inactive state of<Checkbox>— and--sk-bg-4works fineSo there are two or three very minor style adjustments, and in exchange we have a more constrained palette that will be easier to work with. The next step is to develop more consistency around when the various tokens apply, and tweak their values a bit — that can happen in a follow-up PR.