Skip to content

feat: Render full posts on RSS feed #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

martgnz
Copy link
Contributor

@martgnz martgnz commented Dec 5, 2024

Renders the full post in the RSS feed for the svelte blog. With this change the feed will be friendlier for those with unstable connections (e.g. subway) since you can download posts whenever you have a connection rather than having to navigate to an external URL each time. It's a nicer experience since you don't have to move away from your reader.

Closes #837.

Tested on NetNewswire from localhost feed and it works well.

before

imagen

after

imagen

A note on documentation PRs

If this is a documentation PR (i.e. changing content within apps/svelte.dev/content/docs), then this is the wrong repository to make those changes. The content in this folder is synced from other repositories. Therefore, these changes should be made in their respective repositories (at https://github.com/sveltejs/svelte or https://github.com/sveltejs/kit, or example).

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time.
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.

Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 1:38am

Copy link

vercel bot commented Dec 5, 2024

@martgnz is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

<item>
<title>${escapeHTML(post.metadata.title)}</title>
<link>https://svelte.dev/${post.slug}</link>
<author>${escapeHTML(post.metadata.author)}</author>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added author info too

@Rich-Harris Rich-Harris merged commit 140dbff into sveltejs:main Dec 5, 2024
5 checks passed
@Rich-Harris
Copy link
Member

fantastic, thank you!

@martgnz martgnz deleted the full-text-rss branch December 5, 2024 17:34
@martgnz
Copy link
Contributor Author

martgnz commented Dec 5, 2024

@Rich-Harris unfortunately the live endpoint is returning a 500. do you happen to know why? this never happened on localhost development https://svelte.dev/blog/rss.xml

@Rich-Harris
Copy link
Member

getting this rather cryptic error. not sure what could cause it

image

@martgnz
Copy link
Contributor Author

martgnz commented Dec 5, 2024

my guess is that the render function is not happy to get called under that endpoint for some reason (maybe due to path mismatches?). on that function i saw lots of tweaks to make code snippets work on other parts of the site.

there's another markdown renderer on the project with less moving parts maybe could switch to that?

@Rich-Harris Rich-Harris mentioned this pull request Dec 5, 2024
@Rich-Harris
Copy link
Member

don't have time to properly diagnose it but it turns out that prerendering it (which we should have been doing anyway) works around whatever the issue is #943

@martgnz
Copy link
Contributor Author

martgnz commented Dec 5, 2024

thanks so much Rich!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full text in RSS feed
2 participants